Fix a false negative for RSpec/Pending and false positive for RSpec/NoExpectationExample when using skipped in metadata is multiline string
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
commented
Jan 6, 2023
Comment on lines
+10
to
+12
| - Fix a false negative for `RSpec/Pending` when using skipped in metadata is multiline string. ([@ydah]) | ||
| - Fix a false positive for `RSpec/NoExpectationExample` when using skipped in metadata is multiline string. ([@ydah]) |
There was a problem hiding this comment.
[memo] CHANGELOGs are separated for easy reading. Please let us know if it would be better to integrate.
…c/NoExpectationExample` when using skipped in metadata is multiline string Fix: rubocop#1540
Darhazer
approved these changes
Jan 13, 2023
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Jan 13, 2023
3 tasks
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Jan 13, 2023
Darhazer
added a commit
that referenced
this pull request
Jan 13, 2023
Move #1541 changelog to unreleased position
ydah
added a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1540
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).