Stop using newly added cops

[pirj]

lib/rubocop/cop/rspec/multiple_expectations.rb:73:32: W: Lint/ToEnumArguments: Ensure you correctly provided all the arguments.
              expectations_count = to_enum(:find_expectation, node).count
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

(source)

We'd still love to use OUR new cops while working on our codebase, let's see how this option works when set under RSpec namespace when we introduce the first pending cop.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

@bquorning Merge at will.

[bquorning]

Lint/ToEnumArguments: Ensure you correctly provided all the arguments.

I ran into this again recently. I think it’s actually a bug – see also rubocop/rubocop#8941 (comment)

[bquorning]

We'd still love to use OUR new cops while working on our codebase, let's see how this option works when set under RSpec namespace when we introduce the first pending cop.

It doesn’t work.

Warning: RSpec does not support NewCops parameter.

Supported parameters are:

  - Enabled
  - StyleGuideBaseURL
  - Include
  - Language

[pirj]

What if we define NewCops: pending in config/default.yml under RSpec like rubocop does in its config/default.yml?

This could fix the error, but I'm still uncertain if it would work as intended.

Another concern is if changing the root NewCops in project's .rubocop.yml would affect RSpec/NewCops. It feels that it should, but again I'm uncertain.

[bquorning]

What if we define NewCops: pending in config/default.yml under RSpec like rubocop does in its config/default.yml?

Nope, that doesn’t work :sad_panda:

[pirj]

This is quite frustrating, we can't eat our own dogfood 😄