RSpec/Rails/HaveHttpStatus autofix broke test suite

[VitaliySerov]

Hey guys I have a sinatra application:

https://github.com/ONLYOFFICE-QA/sinatra-post-to-redis

some specs in it looks like this:

it 'allows send post notification' do
    post '/', notification: 'hello rspec'

    expect(last_response.status).to eq 200
  end

after upgrading rubocop-rspec and applying auto-update expect line was changes to expect(last_response).to have_http_status :ok

And this changes execution of rspec tests, seems that sinatra apps are not aware of those:

  1) SinatraPostToRedis allows send post notification
     Failure/Error: expect(last_response).to have_http_status :ok
       expected #<Rack::MockResponse:0x00007f68ae7fea68 @original_headers={"Content-Type"=>"text/html;charset=utf-8",....0/gems/rack-2.2.8.1/lib/rack/response.rb:287>, @block=nil, @body=["OK"], @buffered=true, @length=2> to respond to `has_http_status?`
     # ./spec/sinatra_post_to_redis/sinatra_post_to_redis_spec.rb:10:in `block (2 levels) in <top (required)>'

You can see changes here:

ONLYOFFICE-QA/sinatra-post-to-redis@5eb9d7f

[ydah]

@VitaliySerov Thank you for reporting. As the name implies, it's a cop in the Rails department, so we recommend departmental disable in .rubocop.yml as follows. How about setting?

RSpec/Rails:
  Enabled: false

[VitaliySerov]

Yeah, of course, I can disable it

But maybe there should be some fail-safe mechanism in rubocop-rspec so that non-rails applications will not be detected by Rspec/Rails cop?

If it's not possible - I think there should be a line in the readme "please disable Rspec/Rails in case you use rubocop-rspec in non-rails env`

[ydah]

Soon, the RSpec/Rails cop will be cut off to another gem. Users will be able to hire only the departments they need.

• Extract rspec-rails cops #1734

[VitaliySerov]

@ydah All right, seems like a good solution, but I think we can keep my issue opened until the migration is done?

[ydah]

If this is a good solution, I think this issue can be closed because it overlaps with the following issue.

• Extract rspec-rails cops #1734

[VitaliySerov]

Ok, will close it

Thanks for your work :)