-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec/Rails/HaveHttpStatus autofix broke test suite #1823
Comments
@VitaliySerov Thank you for reporting. As the name implies, it's a cop in the Rails department, so we recommend departmental disable in .rubocop.yml as follows. How about setting? RSpec/Rails:
Enabled: false |
Yeah, of course, I can disable it But maybe there should be some fail-safe mechanism in If it's not possible - I think there should be a line in the readme "please disable Rspec/Rails in case you use |
Soon, the RSpec/Rails cop will be cut off to another gem. Users will be able to hire only the departments they need. |
@ydah All right, seems like a good solution, but I think we can keep my issue opened until the migration is done? |
If this is a good solution, I think this issue can be closed because it overlaps with the following issue. |
Ok, will close it Thanks for your work :) |
Hey guys I have a sinatra application:
https://github.com/ONLYOFFICE-QA/sinatra-post-to-redis
some specs in it looks like this:
after upgrading rubocop-rspec and applying auto-update expect line was changes to
expect(last_response).to have_http_status :ok
And this changes execution of rspec tests, seems that sinatra apps are not aware of those:
You can see changes here:
ONLYOFFICE-QA/sinatra-post-to-redis@5eb9d7f
The text was updated successfully, but these errors were encountered: