Allow for Gemfile.local #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
introduce-gemfile-local
branch
from
f3525b2
to
474ff0a
Compare
|
Thanks! |
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Dec 11, 2021
Follow up to rubocop/rubocop-rails#595.
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
Dec 17, 2021
Follow up to rubocop/rubocop-rails#595.
patrickm53
pushed a commit
to patrickm53/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
Follow up to rubocop/rubocop-rails#595.
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
Follow up to rubocop/rubocop-rails#595.
Cute0110
added a commit
to Cute0110/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
Follow up to rubocop/rubocop-rails#595.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Follow up to rubocop/rubocop-rails#595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding dev gems e.g.
pry-byebugwithout keeping a dirtyGemfile.It's done in RuboCop itself https://github.com/rubocop/rubocop/blob/e919a8c216731fadf12c50d2658f9a67a30c5cc7/Gemfile#L29
Luckily enough,
Gemfile.localis already in.gitignore, so this wasn't neededBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.