Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoCorrect: contextual needs rubocop v1.61 #126

Merged
merged 2 commits into from
Jun 11, 2024
Merged

AutoCorrect: contextual needs rubocop v1.61 #126

merged 2 commits into from
Jun 11, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jun 11, 2024

follow up: rubocop/rubocop-rspec#1901


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner June 11, 2024 11:39
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -2,6 +2,8 @@

## Master (Unreleased)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing after 3.0 release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rubocop-factory_bot, not rubocop-rspec :-)

@ydah ydah merged commit 90ed1a1 into master Jun 11, 2024
24 checks passed
@ydah ydah deleted the bump1_61 branch June 11, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants