-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract RuboCop FactoryBot from RuboCop RSpec #1
Conversation
Steps:
rename:
|
My only concern regarding this PR is that |
Indeed it is. I will pushing commits directly to master instead of merging this PR. |
80b0e18
to
af6a602
Compare
e8aa600
to
fc08c81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can delete the rspec4
job from .github/workflows/main.yml, since it’s more rubocop-rspec specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides one comment, the changes look fine to me.
Indeed it is. I updated this PR. Thank you! |
@pirj It seems that the common file operations remain; similar commits remain in rubocop-capybara. |
Please disregard my previous comment. Old unrelated commits are indeed kept there, too rubocop/rubocop-capybara@b02eb14 |
Thanks a lot for this enourmous effort, @ydah ! |
Oh, I too was hoping to get a “clean” commit history. But yeah, I guess it would be very labor intensive to filter commits touching the Changelog file. |
This PR is extract RuboCop FactoryBot from RuboCop RSpec.
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).