Extract RuboCop FactoryBot from RuboCop RSpec

[ydah]

This PR is extract RuboCop FactoryBot from RuboCop RSpec.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[ydah]

Steps:

git clone --no-local rubocop-rspec rubocop-factory_bot-hist
cd rubocop-factory_bot-hist
git-filter-repo $( (cat ../rubocop-factory_bot/rename | xargs -I_ echo '--path-rename _ ') )
git-filter-repo $( (cd ../rubocop-factory_bot && git ls-files) | xargs -I_ echo '--path _ ')
git remote add origin git@github.com:rubocop/rubocop-factory_bot.git
git push --set-upstream origin master
git checkout -b factory_bot-only
cd ../rubocop-factory_bot
cp -r * ../rubocop-factory_bot-hist
cp -r $( git ls-files | grep '^\.' | grep -v '\.github' ) ../rubocop-factory_bot-hist
cp -r .github ../rubocop-factory_bot-hist
cd -
git commit --all --message 'RSpec -> FactoryBot'
bundle install
bundle exec rake
git push origin factory_bot-only

rename:

docs/modules/ROOT/pages/cops_rspec_factorybot.adoc:docs/modules/ROOT/pages/cops_factorybot.adoc
lib/rubocop-rspec.rb:lib/rubocop-factory_bot.rb
lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb:lib/rubocop/cop/factory_bot/attribute_defined_statically.rb
lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb:lib/rubocop/cop/factory_bot/consistent_parentheses_style.rb
lib/rubocop/cop/rspec/factory_bot/create_list.rb:lib/rubocop/cop/factory_bot/create_list.rb
lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb:lib/rubocop/cop/factory_bot/factory_class_name.rb
lib/rubocop/cop/rspec/factory_bot/factory_name_style.rb:lib/rubocop/cop/factory_bot/factory_name_style.rb
lib/rubocop/cop/rspec/factory_bot/syntax_methods.rb:lib/rubocop/cop/factory_bot/syntax_methods.rb
lib/rubocop/cop/rspec_cops.rb:lib/rubocop/cop/factory_bot_cops.rb
lib/rubocop/rspec/config_formatter.rb:lib/rubocop/factory_bot/config_formatter.rb
lib/rubocop/rspec/description_extractor.rb:lib/rubocop/factory_bot/description_extractor.rb
lib/rubocop/rspec/factory_bot.rb:lib/rubocop/factory_bot/factory_bot.rb
lib/rubocop/rspec/factory_bot/language.rb:lib/rubocop/factory_bot/language.rb
lib/rubocop/rspec/version.rb:lib/rubocop/factory_bot/version.rb
rubocop-rspec.gemspec:rubocop-factory_bot.gemspec
spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb:spec/rubocop/cop/factory_bot/attribute_defined_statically_spec.rb
spec/rubocop/cop/rspec/factory_bot/consistent_parentheses_style_spec.rb:spec/rubocop/cop/factory_bot/consistent_parentheses_style_spec.rb
spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb:spec/rubocop/cop/factory_bot/create_list_spec.rb
spec/rubocop/cop/rspec/factory_bot/factory_class_name_spec.rb:spec/rubocop/cop/factory_bot/factory_class_name_spec.rb
spec/rubocop/cop/rspec/factory_bot/factory_name_style_spec.rb:spec/rubocop/cop/factory_bot/factory_name_style_spec.rb
spec/rubocop/cop/rspec/factory_bot/syntax_methods_spec.rb:spec/rubocop/cop/factory_bot/syntax_methods_spec.rb
spec/rubocop/rspec/config_formatter_spec.rb:spec/rubocop/factory_bot/config_formatter_spec.rb
spec/rubocop/rspec/description_extractor_spec.rb:spec/rubocop/factory_bot/description_extractor_spec.rb

Ref: rubocop-hq/rubocop-capybara#1 (comment)

[pirj]

My only concern regarding this PR is that master would still have traces of old file versions from rubocop-rspec.
I'd rather start master from the point where factory_bot-only is.

[ydah]

My only concern regarding this PR is that master would still have traces of old file versions from rubocop-rspec. I'd rather start master from the point where factory_bot-only is.

Indeed it is. I will pushing commits directly to master instead of merging this PR.

[bquorning]

I think you can delete the rspec4 job from .github/workflows/main.yml, since it’s more rubocop-rspec specific.

[bquorning]

Besides one comment, the changes look fine to me.

[ydah]

I think you can delete the rspec4 job from .github/workflows/main.yml, since it’s more rubocop-rspec specific.

Indeed it is. I updated this PR. Thank you!
If all is well, push to master and start this repository.

[pirj]

What concerns me slightly is that we kept unrelated commits from rubocop-rspec.

is this because they touched commonly present files like the changelog and default conf?
I can’t recall if it was the same for rubocop-capybara.
My apologies for such a purist question.

[ydah]

@pirj It seems that the common file operations remain; similar commits remain in rubocop-capybara.
rubocop/rubocop-capybara@29cdd5a

[pirj]

Please disregard my previous comment. Old unrelated commits are indeed kept there, too rubocop/rubocop-capybara@b02eb14

[pirj]

Thanks a lot for this enourmous effort, @ydah !

[bquorning]

Oh, I too was hoping to get a “clean” commit history. But yeah, I guess it would be very labor intensive to filter commits touching the Changelog file.