Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Capybara/CurrentPathExpectation #66

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Aug 28, 2023

Fix: #50


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah
Copy link
Member Author

ydah commented Sep 19, 2023

@jcoyne Could you confirm that this solves problem #50 ?

@jcoyne
Copy link

jcoyne commented Sep 19, 2023

Yes! This works great. Thank you @ydah! 🙇

@ydah ydah merged commit 8696fdd into main Sep 19, 2023
23 checks passed
@ydah ydah deleted the fix/50 branch September 19, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capybara/CurrentPathExpectation is not valid when the page has query parameters
2 participants