Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix the RSpec 4 job #106

Merged
merged 1 commit into from
Feb 27, 2024
Merged

CI: Fix the RSpec 4 job #106

merged 1 commit into from
Feb 27, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Feb 27, 2024

Follow up: rubocop/rubocop-rspec#1817


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah marked this pull request as ready for review February 27, 2024 01:32
@ydah ydah requested a review from a team as a code owner February 27, 2024 01:32
@pirj pirj merged commit 4266d6e into main Feb 27, 2024
25 checks passed
@pirj pirj deleted the fix-rspec-4-on-ci branch February 27, 2024 04:40
@pirj
Copy link
Member

pirj commented Feb 27, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants