-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change logic for when to use EOL disable comment
The decision whether to use a single EOL comment to disable a cop, or a disable/enable pair on separate lines, should not be based on whether the code range of the offense is single line or multi-line. It should be based on whether the comment fits on the given line. The single line comment WILL disable the offense even if it's reported on a multi-line range. We also need to make sure we don't add more than one EOL comment per line (fix later).
- Loading branch information
Showing
3 changed files
with
113 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters