Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double functionality for getter and setter #4

Open
Naoghuman opened this issue Nov 14, 2015 · 0 comments
Open

Double functionality for getter and setter #4

Naoghuman opened this issue Nov 14, 2015 · 0 comments

Comments

@Naoghuman
Copy link
Collaborator

Hi Rob,
I have done a litte analyse in reference for generic generation and seen that with the plugin the functionality for the generation from the getter and setter is doubled.

The plugin add the functionality for generating getter and setters immediatly with the new action 'JavaFx Getter and Setter...', but also the standard functionalities in the actions 'Getter..., Setter... and Getter and Setter...' in the popup 'Generate' will generate JavaFx getter and setter after the selection from JavaFx properties in the 'Generate Getter (and Setter) panel' (when also the generated sourcecode dont follow the JavaFX Naming Convention and the third method is missing).

So what I see to solve this problem is

  • We can remove the standard actions from NetBeans and extend the new action from the plugin so that it also can generate normal Java properties.
  • We can extend the standard actions from NetBeans so that they can also generate JavaFX properties which follow the JavaFX Naming Convention and add the third method. But then we dont need the new action.
  • Its also possible to extend the standard action and the new action but this solution I guess is not so clean (double work).

For the second solution I have the idea to extend the 'Generate Getter (and Setter) panel'. At top then there is the JTree 'Select Java fields for generate...' and below a new JTree 'Select JavaFX fields for generate...'. What also speak for the solution with the extension from the standard actions is

  • that the standard actions have the selection panel
  • the standard actions can generate generic methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants