Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logic for finding a region's cover image isn't always reliable #3

Open
rsvensson opened this issue May 31, 2020 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@rsvensson
Copy link
Owner

Summary
Occasionally when fetchinfo.py's getMobyRelease() function attempts to find the cover for certain regions, it can't seem to find the right cover and instead selects another one. This seems to mostly affect PAL releases.

For example, when searching for the PAL cover of Donkey Kong Country 3: Dixie Kong's Double Trouble! it instead comes back with the Japanese cover, even though there are several PAL covers to choose from.

Other examples are sometimes selecting a non-English PAL cover when there is one available (such as here), and sometimes the wrong English PAL cover (such as here where it chooses the slip-case release instead of the normal UK release)

Expected result
Well the logic for finding the cover is quite messy and needs cleanup, so it's not unexpected that it has issues. Still, it should ultimately behave as intended and only fall back to the wrong image if no other suitable image is found.

@rsvensson rsvensson added the bug Something isn't working label May 31, 2020
@rsvensson rsvensson self-assigned this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant