Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column names with spaces causes incorrect validation error #530

Closed
6 tasks done
JamesHWade opened this issue Mar 14, 2024 · 1 comment · Fixed by #531
Closed
6 tasks done

Column names with spaces causes incorrect validation error #530

JamesHWade opened this issue Mar 14, 2024 · 1 comment · Fixed by #531
Assignees

Comments

@JamesHWade
Copy link

Prework

Description

When using col_val_lt(), I get an error if there is a space in the column name. This also occurs with col_val_gt().

Reproducible example

I removed the HTML from the reprex.

library(pointblank)
mtcars |> 
  dplyr::rename(`disp units` = disp) |>
  create_agent() |> 
  col_vals_lt(`disp units`, 1000) |> 
  interrogate()

Created on 2024-03-14 with reprex v2.1.0

  • Post a minimal reproducible example so the maintainer can troubleshoot the problems you identify. A reproducible example is:
    • Runnable: post enough R code and data so any onlooker can create the error on their own computer.
    • Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
    • Readable: format your code according to the tidyverse style guide.

Expected result

The validation should proceed instead of result in an error.

Session info

End the reproducible example with a call to sessionInfo() in the same session (e.g. reprex(session_info = TRUE)) and include the output.

@yjunechoe
Copy link
Collaborator

Thanks for the report! I can reproduce this - it's a bug in the tbl_val_comparison() function that powers col_vals_lt().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants