Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.0 and Ruby 3.1 to build matrix #2548

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Conversation

@pirj pirj self-assigned this Dec 30, 2021
allow_failure: true
env:
RAILS_VERSION: '~> 7.0.0'
- ruby: 3.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 🙌

You should use '3.0' otherwise github actions will pull 3.1. Related to this actions/runner#849 / ruby/setup-ruby#252
image

I guess, all other ruby versions should be quoted too? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing!
I guess only x.0 versions are affected.

@pirj pirj force-pushed the add-ruby-3.1-rails-7-releases branch from 0e9ccac to 517deae Compare December 30, 2021 15:48
@pirj
Copy link
Member Author

pirj commented Dec 30, 2021

Job failures are unrelated, will fix in a follow-up. rubygems are out of date. We've removed update_rubygems_and_install_bundler step when migrated from Travis to GHA:

     Failure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
       expected `"Your RubyGems version (2.7.6.3)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
      Failure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
       expected `"Your RubyGems version (2.6.14.4)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
     # /home/runner/work/rspec-rails/rspec-support/lib/rspec/support.rb:102:in `block in <module:Support>'
      Failure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
       expected `"Your RubyGems version (2.7.6.2)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
      Failure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
       expected `"Your RubyGems version (2.5.2.3)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false

@pirj pirj merged commit 4e91be3 into main Dec 30, 2021
@pirj pirj deleted the add-ruby-3.1-rails-7-releases branch December 30, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants