-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the raw connection ivar to @raw_connection
#2265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
rename_raw_connection_ivar
branch
from
February 25, 2022 17:49
7fb630d
to
5c51e56
Compare
koic
force-pushed
the
rename_raw_connection_ivar
branch
from
February 25, 2022 18:02
5c51e56
to
8e574d9
Compare
The following CI failure seem to be resolved by merging this PR into master branch. Run cd guides/bug_report_templates
Fetching https://github.com/rsim/oracle-enhanced.git
Fetching https://github.com/rails/rails.git
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Using concurrent-ruby 1.1.9
Using minitest 5.15.0
Fetching ruby-oci8 2.2.11
Fetching ruby-plsql 0.8.0
Installing ruby-plsql 0.8.0
Installing ruby-oci8 2.2.11 with native extensions
Using bundler 2.3.8
Using i[18](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:18)n 1.10.0
Using tzinfo 2.0.4
Using activesupport 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activemodel 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activerecord 7.1.0.alpha from https://github.com/rails/rails.git (at main@49299c4)
Using activerecord-oracle_enhanced-adapter 7.1.0.alpha from https://github.com/rsim/oracle-enhanced.git (at master@c[26](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:26)f3ec)
/opt/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/bundler/gems/oracle-enhanced-c26f3ec0a[29](https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:29)c/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:682:in `get_database_version': undefined method `database_version' for nil:NilClass (NoMethodError)
@connection.database_version
^^^^^^^^^^^^^^^^^
from /opt/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/bundler/gems/rails-49299c4f82db/activerecord/lib/active_record/connection_adapters/schema_cache.rb:145:in `database_version' https://github.com/rsim/oracle-enhanced/runs/5337457268?check_suite_focus=true#step:13:1 |
yahonda
added a commit
to yahonda/ruby-plsql
that referenced
this pull request
Mar 17, 2022
This commit addresses these two failures against Rails main branch. https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660 ``` Failures: 1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>' 2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>' Finished in 13.12 seconds (files took 0.35468 seconds to load) 453 examples, 2 failures, 3 pending ``` Related to rsim/oracle-enhanced#2265 Follow up rails/rails#44530
yahonda
added a commit
to yahonda/ruby-plsql
that referenced
this pull request
Mar 17, 2022
This commit addresses these two failures against Rails main branch. https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660 ``` Failures: 1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>' 2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>' Finished in 13.12 seconds (files took 0.35468 seconds to load) 453 examples, 2 failures, 3 pending ``` Related to rsim/oracle-enhanced#2265 Follow up rails/rails#44530
yahonda
added a commit
to yahonda/ruby-plsql
that referenced
this pull request
Mar 17, 2022
This commit addresses these two failures against Rails main branch. https://app.travis-ci.com/github/rsim/ruby-plsql/jobs/563373660 ``` Failures: 1) DBMS_OUTPUT logging with Activerecord connection should log output to specified stream Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:352:in `block (3 levels) in <top (required)>' 2) DBMS_OUTPUT logging with Activerecord connection should log output after reconnection Failure/Error: tdo = raw_oci_connection.get_tdo_by_class(value.class) NoMethodError: undefined method `get_tdo_by_class' for nil:NilClass tdo = raw_oci_connection.get_tdo_by_class(value.class) ^^^^^^^^^^^^^^^^^ # ./lib/plsql/oci_connection.rb:263:in `ora_value_to_ruby_value' # ./lib/plsql/oci_connection.rb:112:in `[]' # ./lib/plsql/procedure_call.rb:602:in `dbms_output_lines' # ./lib/plsql/procedure_call.rb:620:in `dbms_output_log' # ./lib/plsql/procedure_call.rb:41:in `exec' # ./lib/plsql/procedure.rb:546:in `exec' # ./lib/plsql/schema.rb:185:in `method_missing' # ./spec/plsql/schema_spec.rb:358:in `block (3 levels) in <top (required)>' Finished in 13.12 seconds (files took 0.35468 seconds to load) 453 examples, 2 failures, 3 pending ``` Related to rsim/oracle-enhanced#2265 Follow up rails/rails#44530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rails/rails#44530.