Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix columns_for_distinct when using Rails 6.1 #2249

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix columns_for_distinct when using Rails 6.1 #2249

merged 1 commit into from
Jan 20, 2022

Commits on Jan 19, 2022

  1. Fix columns_for_distinct when using Rails 6.1 

    Running `ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` in Rails 6.1.4.4 will result in an error.

```
ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
Using oracle
Warning: NLS_LANG is not set. fallback to US7ASCII.
Run options: -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct --seed 32511

# Running:

F

Failure:
FinderTest#test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct [./test/cases/finder_test.rb:1503]:
Expected: 2
  Actual: 1

rails test ./test/cases/finder_test.rb:1502

Finished in 1.275346s, 0.7841 runs/s, 0.7841 assertions/s.
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
```

Changing the return value of `columns_for_distinct` causes the test to pass.
This is a fix for the change to PostgreSQL and MySQL adapters in Rails 6.0. rails/rails#31966

The reason why the tests for  `ARCONN=oracle bundle exec ruby -Itest ./test/cases/finder_test.rb -n test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` don't pass is because of a fix in finder_methods.rb in Rails 6.1.
rails/rails@2ad2425
    @swamp09
    swamp09 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    1c6ee6c View commit details
    Browse the repository at this point in the history