Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default_timezone a module instance variable #2190

Merged

Conversation

koic
Copy link
Collaborator

@koic koic commented Jun 17, 2021

@yahonda
Copy link
Collaborator

yahonda commented Jun 17, 2021

@koic Thanks for opening a pull request. Would you address the conflict at spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb ?

@yahonda yahonda self-requested a review June 17, 2021 05:49
@koic koic force-pushed the make_default_timezone_a_module_instance_variable branch from 60f70e7 to 1afaa3d Compare June 17, 2021 06:03
@koic
Copy link
Collaborator Author

koic commented Jun 17, 2021

@yahonda I rebased this PR with the latest master branch.

@yahonda yahonda merged commit 6ce404a into rsim:master Jun 17, 2021
Copy link
Collaborator

@yahonda yahonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@koic koic deleted the make_default_timezone_a_module_instance_variable branch June 17, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants