Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent from including ojdbc8.jar file to gem file #2164

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Prevent from including ojdbc8.jar file to gem file #2164

merged 1 commit into from
Apr 1, 2021

Conversation

yahonda
Copy link
Collaborator

@yahonda yahonda commented Apr 1, 2021

Fix #2163

  • Without this change - ojdbc8.jar file is included in the gem file.
$ cp /usr/lib/oracle/19.8/client64/lib/ojdbc8.jar lib/.
$ bundle exec rake build
activerecord-oracle_enhanced-adapter 7.0.0.alpha built to pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem.
$ ls -lh pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
-rw-rw-r-- 1 yahonda yahonda 4.0M Apr  1 12:14 pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
cd pkg
$ gem unpack activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
Unpacked gem: '/home/yahonda/src/github.com/rsim/oracle-enhanced/pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha'
$ ls -l activerecord-oracle_enhanced-adapter-7.0.0.alpha/lib/
total 4252
drwxrwxr-x 4 yahonda yahonda    4096 Apr  1 12:14 active_record
-rw-rw-r-- 1 yahonda yahonda     442 Apr  1 12:14 activerecord-oracle_enhanced-adapter.rb
drwxrwxr-x 3 yahonda yahonda    4096 Apr  1 12:14 arel
-rw-r--r-- 1 yahonda yahonda 4340768 Apr  1 12:14 ojdbc8.jar
$
  • With this change - ojdbc8.jar file is not included in the gem file.
$ cp /usr/lib/oracle/19.8/client64/lib/ojdbc8.jar lib/.
$ bundle exec rake build
activerecord-oracle_enhanced-adapter 7.0.0.alpha built to pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem.
$ ls -lh pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
-rw-rw-r-- 1 yahonda yahonda 116K Apr  1 12:22 pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
$ cd pkg
$ gem unpack activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
Unpacked gem: '/home/yahonda/src/github.com/rsim/oracle-enhanced/pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha'
$ ls -l activerecord-oracle_enhanced-adapter-7.0.0.alpha/lib/
total 12
drwxrwxr-x 4 yahonda yahonda 4096 Apr  1 12:23 active_record
-rw-rw-r-- 1 yahonda yahonda  442 Apr  1 12:23 activerecord-oracle_enhanced-adapter.rb
drwxrwxr-x 3 yahonda yahonda 4096 Apr  1 12:23 arel
$

@yahonda
Prevent from including ojdbc8.jar file to gem file
5ad924c 
Fix rsim#2163

- Without this change - ojdbc8.jar file is included in the gem file.

```
$ cp /usr/lib/oracle/19.8/client64/lib/ojdbc8.jar lib/.
$ bundle exec rake build
activerecord-oracle_enhanced-adapter 7.0.0.alpha built to pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem.
$ ls -lh pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
-rw-rw-r-- 1 yahonda yahonda 4.0M Apr  1 12:14 pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
cd pkg
$ gem unpack activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
Unpacked gem: '/home/yahonda/src/github.com/rsim/oracle-enhanced/pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha'
$ ls -l activerecord-oracle_enhanced-adapter-7.0.0.alpha/lib/
total 4252
drwxrwxr-x 4 yahonda yahonda    4096 Apr  1 12:14 active_record
-rw-rw-r-- 1 yahonda yahonda     442 Apr  1 12:14 activerecord-oracle_enhanced-adapter.rb
drwxrwxr-x 3 yahonda yahonda    4096 Apr  1 12:14 arel
-rw-r--r-- 1 yahonda yahonda 4340768 Apr  1 12:14 ojdbc8.jar
$
```

- With this change - ojdbc8.jar file is not included in the gem file.

```
$ cp /usr/lib/oracle/19.8/client64/lib/ojdbc8.jar lib/.
$ bundle exec rake build
activerecord-oracle_enhanced-adapter 7.0.0.alpha built to pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem.
$ ls -lh pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
-rw-rw-r-- 1 yahonda yahonda 116K Apr  1 12:22 pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
$ cd pkg
$ gem unpack activerecord-oracle_enhanced-adapter-7.0.0.alpha.gem
Unpacked gem: '/home/yahonda/src/github.com/rsim/oracle-enhanced/pkg/activerecord-oracle_enhanced-adapter-7.0.0.alpha'
$ ls -l activerecord-oracle_enhanced-adapter-7.0.0.alpha/lib/
total 12
drwxrwxr-x 4 yahonda yahonda 4096 Apr  1 12:23 active_record
-rw-rw-r-- 1 yahonda yahonda  442 Apr  1 12:23 activerecord-oracle_enhanced-adapter.rb
drwxrwxr-x 3 yahonda yahonda 4096 Apr  1 12:23 arel
$
```
@yahonda yahonda requested a review from koic April 1, 2021 03:34
@yahonda
Copy link
Collaborator Author

yahonda commented Apr 1, 2021

@koic Would you review this pull request because you gave me some useful comments in #2163.

koic
koic approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you!

@koic koic merged commit 0716281 into rsim:master Apr 1, 2021
@yahonda
Copy link
Collaborator Author

yahonda commented Apr 1, 2021

Thanks for the review.

yahonda pushed a commit to yahonda/oracle-enhanced that referenced this pull request Apr 1, 2021
@koic @yahonda
Merge pull request rsim#2164 from yahonda/diag2163
b171a6d 
Prevent from including ojdbc8.jar file to gem file
@yahonda yahonda mentioned this pull request Apr 1, 2021
Merged
yahonda added a commit that referenced this pull request Apr 1, 2021
@yahonda
Merge pull request #2165 from yahonda/backport_2164_to_release61
d4a5890 
Merge pull request #2164 from yahonda/diag2163
@yahonda yahonda deleted the diag2163 branch June 9, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to prevent from including ojdbc8.jar file to gem file
2 participants
@yahonda @koic