Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of SuggestExtensions message #2133

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

koic
Copy link
Collaborator

@koic koic commented Jan 31, 2021

Follow rails/rails@458f19a

This PR suppresses the following SuggestExtensions message.

% bundle exec rubocop
(snip)

70 files inspected, no offenses detected

Tip: Based on detected gems, the following RuboCop extension libraries
might be helpful:
* rubocop-rake (http://github.com/rubocop-hq/rubocop-rake)
* rubocop-rspec (http://github.com/rubocop-hq/rubocop-rspec)

You can opt out of this message by adding the following to your config (see
https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
AllCops:
  SuggestExtensions: false

I think Oracle enhanced adapter will not add its own 3rd party gems because the adapter coding style is based on Rails.

Follow rails/rails@458f19a

This PR suppresses the following `SuggestExtensions` message.

```console
% bundle exec rubocop
(snip)

70 files inspected, no offenses detected

Tip: Based on detected gems, the following RuboCop extension libraries
might be helpful:
* rubocop-rake (http://github.com/rubocop-hq/rubocop-rake)
* rubocop-rspec (http://github.com/rubocop-hq/rubocop-rspec)

You can opt out of this message by adding the following to your
config (see
https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions
for more options):
AllCops:
  SuggestExtensions: false
```

I think Oracle enhanced adapter will not add its own 3rd party gems
because the adapter coding style is based on Rails.
@yahonda yahonda merged commit 471676d into rsim:master Feb 3, 2021
@koic koic deleted the opt_out_of_suggest_extensions_message branch February 3, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants