Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of bind variables for volatile filter conditions (2) #2087

Closed
wants to merge 44 commits into from
Closed

Usage of bind variables for volatile filter conditions (2) #2087

wants to merge 44 commits into from

Commits on Dec 7, 2020

  1. Merge pull request #1 from rsim/master

    Refresh fork
    rammpeter authored Dec 7, 2020
    Configuration menu
    Copy the full SHA
    35a34d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Usage of bind variables for volatile filter conditions.

    This is useful especially in case of cursor_sharing=exact
    
    (cherry picked from commit f8b7a1a)
    rammpeter committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    600e920 View commit details
    Browse the repository at this point in the history
  2. Fix rubycop findings

    (cherry picked from commit f8021f8)
    rammpeter committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    4c62d48 View commit details
    Browse the repository at this point in the history
  3. Allow usage of JDBC statement caching by DB config parameter (#2088)

    * Set JDBC statement cache size in database config
    
    (cherry picked from commit 1c52814)
    
    * Fix rubocop findings
    
    (cherry picked from commit e099b4f)
    rammpeter authored Dec 16, 2020
    Configuration menu
    Copy the full SHA
    b6be4a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2020

  1. Configuration menu
    Copy the full SHA
    32f2d66 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2091 from yahonda/ci_against_ruby3

    CI against Ruby 3.0.0
    yahonda authored Dec 25, 2020
    Configuration menu
    Copy the full SHA
    9f464c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Configuration menu
    Copy the full SHA
    e913253 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2094 from yahonda/exclude_ruby31_now

    Exclude `ruby-head` and `ruby-debug` until minitest allows Ruby 3.1
    yahonda authored Dec 30, 2020
    Configuration menu
    Copy the full SHA
    8b2937c View commit details
    Browse the repository at this point in the history
  3. Do not mark wontfix is upstream label attached

    Related to #2025
    yahonda committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    dc94749 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2096 from yahonda/no_wontfix_if_upstream_labeled

    Do not mark `wontfix` is `upstream` label attached
    yahonda authored Dec 30, 2020
    Configuration menu
    Copy the full SHA
    2318ff5 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Fix write_lobs Invalid byte sequence in UTF-8 (#2097)

    * Fix write_lobs "invalid byte sequence in UTF-8"
    
    write_lobs checks to see whether the value is blank before executing the SQL statement. If the LOB is binary blank? call causes "invalid byte sequence in UTF-8" exception. We can instead use unless value, which is applicable both to strings and binary data.
    
    * check serialized columns to be nil
    
    ActiveRecord persists empty Array ([]) and Hash ({}) as nil. So, after serializing the value need to check again.
    
    * Save non UTF-8 string in binary column
    
    * Fix layout offense
    
    * Fix space offenses
    
    * copy test string in order to force encoding
    
    * Use unary plus to unfreeze
    yegayazilim authored Jan 1, 2021
    Configuration menu
    Copy the full SHA
    c184d57 View commit details
    Browse the repository at this point in the history
  2. Require rspec/autorun to run one line spec file

    * Without this commit
    
    ```ruby
    $ ruby active_record_gem_spec.rb
    Fetching https://github.com/rails/rails.git
    ... snip ...
    Using rails 6.2.0.alpha from https://github.com/rails/rails.git (at master@afc79e3)
    $
    ```
    
    * With this commit
    
    ```ruby
    $ ruby active_record_gem_spec.rb
    Fetching https://github.com/rails/rails.git
    ... snip ...
    Using rails 6.2.0.alpha from https://github.com/rails/rails.git (at master@afc79e3)
    -- create_table(:posts, {:force=>true})
    D, [2021-01-01T17:27:35.727438 #554514] DEBUG -- :    (20.9ms)  DROP TABLE "POSTS"
    D, [2021-01-01T17:27:35.733266 #554514] DEBUG -- :    (5.4ms)  DROP SEQUENCE "POSTS_SEQ"
    D, [2021-01-01T17:27:35.748060 #554514] DEBUG -- :    (14.4ms)  CREATE TABLE "POSTS" ("ID" NUMBER(38) NOT NULL PRIMARY KEY)
    D, [2021-01-01T17:27:35.751081 #554514] DEBUG -- :    (2.8ms)  CREATE SEQUENCE "POSTS_SEQ" START WITH 1
       -> 0.1797s
    -- create_table(:comments, {:force=>true})
    D, [2021-01-01T17:27:35.869071 #554514] DEBUG -- :    (21.4ms)  DROP TABLE "COMMENTS"
    D, [2021-01-01T17:27:35.875660 #554514] DEBUG -- :    (6.3ms)  DROP SEQUENCE "COMMENTS_SEQ"
    D, [2021-01-01T17:27:35.884094 #554514] DEBUG -- :    (8.0ms)  CREATE TABLE "COMMENTS" ("ID" NUMBER(38) NOT NULL PRIMARY KEY, "POST_ID" NUMBER(38))
    D, [2021-01-01T17:27:35.887143 #554514] DEBUG -- :    (2.8ms)  CREATE SEQUENCE "COMMENTS_SEQ" START WITH 1
       -> 0.1359s
    D, [2021-01-01T17:27:36.043216 #554514] DEBUG -- :   ActiveRecord::InternalMetadata Load (1.4ms)  SELECT "AR_INTERNAL_METADATA".* FROM "AR_INTERNAL_METADATA" WHERE "AR_INTERNAL_METADATA"."KEY" = :a1 FETCH FIRST :a2 ROWS ONLY  [["key", "environment"], ["LIMIT", 1]]
    D, [2021-01-01T17:27:36.688610 #554514] DEBUG -- :   Post Create (8.4ms)  INSERT INTO "POSTS" ("ID") VALUES (:a1)  [["id", 1]]
    D, [2021-01-01T17:27:37.203028 #554514] DEBUG -- :   Comment Create (7.5ms)  INSERT INTO "COMMENTS" ("ID") VALUES (:a1)  [["id", 1]]
    D, [2021-01-01T17:27:37.214316 #554514] DEBUG -- :   Comment Update (3.7ms)  UPDATE "COMMENTS" SET "POST_ID" = :a1 WHERE "COMMENTS"."ID" = :a2  [["post_id", 1], ["id", 1]]
    D, [2021-01-01T17:27:37.221641 #554514] DEBUG -- :    (5.0ms)  SELECT COUNT(*) FROM "COMMENTS" WHERE "COMMENTS"."POST_ID" = :a1  [["post_id", 1]]
    D, [2021-01-01T17:27:37.226691 #554514] DEBUG -- :    (4.2ms)  SELECT COUNT(*) FROM "COMMENTS"
    D, [2021-01-01T17:27:37.231298 #554514] DEBUG -- :   Comment Load (3.5ms)  SELECT "COMMENTS".* FROM "COMMENTS" ORDER BY "COMMENTS"."ID" ASC FETCH FIRST :a1 ROWS ONLY  [["LIMIT", 1]]
    D, [2021-01-01T17:27:37.236094 #554514] DEBUG -- :   Post Load (3.2ms)  SELECT "POSTS".* FROM "POSTS" WHERE "POSTS"."ID" = :a1 FETCH FIRST :a2 ROWS ONLY  [["id", 1], ["LIMIT", 1]]
    .
    
    Finished in 1.67 seconds (files took 0.1944 seconds to load)
    1 example, 0 failures
    
    $
    ```
    
    Refer
    https://relishapp.com/rspec/rspec-core/v/3-6/docs/command-line/run-with-ruby-command
    yahonda committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    e3c59d6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2098 from yahonda/rspec_autorun

    Require `rspec/autorun` to run one line spec file
    yahonda authored Jan 1, 2021
    Configuration menu
    Copy the full SHA
    9184757 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2021

  1. Ensure that dictionary access is done properly with prepared SQL and …

    …binds even if primary SQL is executed with connection.unprepared_statement (like behavior of AR.to_sql).
    
    Preserves the function of fix for issue #1687.
    rammpeter committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    b9775fc View commit details
    Browse the repository at this point in the history
  2. Fix rubocop issue

    rammpeter committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    2026b4f View commit details
    Browse the repository at this point in the history
  3. retrigger checks

    rammpeter committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    48575d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Configuration menu
    Copy the full SHA
    917d842 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2102 from rsim/revert-2098-rspec_autorun

    Revert "Require `rspec/autorun` to run one line spec file"
    yahonda authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    021cdaf View commit details
    Browse the repository at this point in the history
  3. retrigger tests

    rammpeter committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    9989df7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Configuration menu
    Copy the full SHA
    3349c35 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2107 from yahonda/enable_lint_duplicate_require_cop

    Enable `Lint/DuplicateRequire` cop
    koic authored Jan 9, 2021
    Configuration menu
    Copy the full SHA
    1924e96 View commit details
    Browse the repository at this point in the history
  3. Enable Layout/SpaceBeforeBrackets cop

    This cop should work with RuboCop 1.8 which includes rubocop/rubocop#9291
    
    ```ruby
    $ bundle exec rubocop -a
    Inspecting 71 files
    ...........................C...........................................
    
    Offenses:
    
    lib/active_record/connection_adapters/oracle_enhanced_adapter.rb:495:39: C: [Corrected] Layout/SpaceBeforeBrackets: Remove the space before the opening brackets.
              @do_not_prefetch_primary_key [table_name] = do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name)
                                          ^
    
    71 files inspected, 1 offense detected, 1 offense corrected
    
    Tip: Based on detected gems, the following RuboCop extension libraries might be helpful:
      * rubocop-rake (http://github.com/rubocop-hq/rubocop-rake)
      * rubocop-rspec (http://github.com/rubocop-hq/rubocop-rspec)
    
    You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
      AllCops:
        SuggestExtensions: false
    $
    ```
    Refer rubocop/rubocop#9305
    yahonda committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    ccb3134 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Ensure FKs are properly included in structure dumps

    Due to a bug, the SQL describing them was being discarded
    joshpencheon committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    fac40bb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Merge pull request #2109 from joshpencheon/fix-fk-structure-dump-incl…

    …usion-bug
    
    Ensure FKs are properly included in structure dumps
    yahonda authored Jan 12, 2021
    Configuration menu
    Copy the full SHA
    126346c View commit details
    Browse the repository at this point in the history
  2. Revert "Disable Travis CI"

    yahonda authored Jan 12, 2021
    Configuration menu
    Copy the full SHA
    f34e9e7 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2108 from yahonda/enable_layout_space_before_brac…

    …kets_cop
    
    Enable `Layout/SpaceBeforeBrackets` cop
    yahonda authored Jan 12, 2021
    Configuration menu
    Copy the full SHA
    dee5ec0 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2115 from rsim/revert-2060-farewall_travis

    Revert "Disable Travis CI"
    yahonda authored Jan 12, 2021
    Configuration menu
    Copy the full SHA
    4868d78 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2086 from yahonda/address_travis_ci_warinings_rel…

    …ease61
    
    Address Travis CI warnings and bump Ubuntu version to 20.04
    yahonda committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    417f454 View commit details
    Browse the repository at this point in the history
  6. CI against Ruby 3.0.0

    * Ruby 3.0.0 Released
    https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
    
    Kind of cherry-pick #2093 to master
    yahonda committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6b35cd8 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #2085 from yahonda/bump_jruby_92140_release61

    CI against JRuby 9.2.14.0
    yahonda committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    cf7cc6a View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2116 from yahonda/tidy_up_travis

    Tidy up Travis CI configuration
    yahonda authored Jan 12, 2021
    Configuration menu
    Copy the full SHA
    daa7711 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    c790259 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2117 from yahonda/jruby_allow_failures

    Allow failures for JRuby
    yahonda authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    3bce56b View commit details
    Browse the repository at this point in the history
  3. Remove /*+ OPTIMIZER_FEATURES_ENABLE('11.2.0.2') */ hint for all_syno…

    …nyms
    
    Since #2055 added /*+ OPTIMIZER_FEATURES_ENABLE('11.2.0.2') */ hint
    to most of the SCHEMA queries and there are performance regressions
    reported for queries to all_synonyms
    
    Fix #2090
    yahonda committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    df2be45 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2110 from yahonda/diag_2090

    Remove /*+ OPTIMIZER_FEATURES_ENABLE('11.2.0.2') */ hint for all_synonyms
    yahonda authored Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c7839e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Configuration menu
    Copy the full SHA
    8f8cf80 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2123 from yahonda/prepare_v611

    Prepare release v6.1.1 [skip ci]
    yahonda authored Jan 14, 2021
    Configuration menu
    Copy the full SHA
    6a5a9a5 View commit details
    Browse the repository at this point in the history
  3. structure dump: read column comments from all_tab_cols

    ...and filter by owner, rather than using user_tab_columns. Ensures column
    comments are dumped for the current schema
    joshpencheon committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    7156d3d View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2121 from joshpencheon/fix-dumping-column-comment…

    …s-across-schemas
    
    structure dump: read column comments from all_tab_cols
    yahonda authored Jan 14, 2021
    Configuration menu
    Copy the full SHA
    6bdf82d View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Usage of bind variables for volatile filter conditions.

    This is useful especially in case of cursor_sharing=exact
    
    (cherry picked from commit f8b7a1a)
    rammpeter committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    005453b View commit details
    Browse the repository at this point in the history
  2. Fix rubycop findings

    (cherry picked from commit f8021f8)
    rammpeter committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    01d79d6 View commit details
    Browse the repository at this point in the history
  3. Ensure that dictionary access is done properly with prepared SQL and …

    …binds even if primary SQL is executed with connection.unprepared_statement (like behavior of AR.to_sql).
    
    Preserves the function of fix for issue #1687.
    rammpeter committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fa5387c View commit details
    Browse the repository at this point in the history
  4. Fix rubocop issue

    rammpeter committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    7d1e4da View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/rammpeter_bind_usage' into rammp…

    …eter_bind_usage
    
    # Conflicts:
    #	lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb
    rammpeter committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d76526b View commit details
    Browse the repository at this point in the history