create_table_definition and add_column take keyword arguments #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The master branch failed as reported by #1943. This failure is based on it. |
|
@koic Would you rebase this pull request based on the current master? Some of failures reported at #1943 have been fixed by rails/rails#37646 . Then remaining two failures are isolated. |
koic
force-pushed
the
create_table_definition_takes_kwargs
branch
from
2bb5bc3
to
13abef9
Compare
|
@yahonda Thanks for the fixing. I rebased this PR. |
|
No regressions found for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of rails/rails@d700456, rails/rails@e02b3d1, and rails/rails@70afbf2