Merge pull request #2146 from koic/select_all_to_be_performed_asynchr…

…onously_from_background_thread_pool Allow Adapter#select_all to be performed asynchronously from a background thread pool
rsim · Feb 10, 2021 · 2660ed2 · 2660ed2
2 parents 9a92d32 + e1a59f4
commit 2660ed2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb b/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb
@@ -9,19 +9,19 @@ module DatabaseStatements
         # see: abstract/database_statements.rb
 
         # Executes a SQL statement
-        def execute(sql, name = nil)
-          log(sql, name) { @connection.exec(sql) }
+        def execute(sql, name = nil, async: false)
+          log(sql, name, async: async) { @connection.exec(sql) }
         end
 
         def clear_cache! # :nodoc:
           reload_type_map
           super
         end
 
-        def exec_query(sql, name = "SQL", binds = [], prepare: false)
+        def exec_query(sql, name = "SQL", binds = [], prepare: false, async: false)
           type_casted_binds = type_casted_binds(binds)
 
-          log(sql, name, binds, type_casted_binds) do
+          log(sql, name, binds, type_casted_binds, async: async) do
             cursor = nil
             cached = false
             with_retry do

diff --git a/lib/active_record/connection_adapters/oracle_enhanced/dbms_output.rb b/lib/active_record/connection_adapters/oracle_enhanced/dbms_output.rb
@@ -31,7 +31,7 @@ def dbms_output_enabled?
         end
 
       private
-        def log(sql, name = "SQL", binds = [], type_casted_binds = [], statement_name = nil)
+        def log(sql, name = "SQL", binds = [], type_casted_binds = [], statement_name = nil, async: false)
           super
         ensure
           log_dbms_output if dbms_output_enabled?