This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
suggested changes
Apr 14, 2020
use multihash::Sha2_256; | ||
|
||
#[tokio::test] | ||
async fn test_inner_local() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test looks incomplete...?
koivunej
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to squash and merge, since the first commit has only WIP
as subject.
Test failures look transient... |
Fixed the commit msg 👍 |
koivunej
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this in. I'll need to work on the stream err handling and we'll need to go over my proposed changes.
Adding list to BlockStore trait and cleanup support Adding list functionality and tests wip dag put Update Cargo.toml Co-Authored-By: Joonas Koivunen <joonas.koivunen@gmail.com> Update Cargo.toml Delete config rustfmt fix: examples and unused" fix: switching back to Vecs feat: adding list functions to repo and ipfs feat: working endpoint fix: more sane newline adding fix: clippy fix: cargo fmt fix: inner Result fix: warp filter chain fixes part 1 fix: HandledErr and some cargo fmt fix: StringError removing HandledErr fix: HandledErr fix: unwrap placement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a conformance-passing
/api/v0/refs/local
endpoint.I added a
list
function to theBlockStore
trait.TODO:
Result
, but maybe not. It seems like there are possibilities for failure at many stepsNote that this includes the work from #137 and will be rebased