Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inline images: add load listeners not replace #1172

Closed
1 task done
pavlogavryliuk opened this issue Mar 9, 2023 · 0 comments · Fixed by #1174 or #1175 · May be fixed by PostHog/rrweb#1
Closed
1 task done

[Bug]: Inline images: add load listeners not replace #1172

pavlogavryliuk opened this issue Mar 9, 2023 · 0 comments · Fixed by #1174 or #1175 · May be fixed by PostHog/rrweb#1
Labels
bug Something isn't working

Comments

@pavlogavryliuk
Copy link

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

v2.0.0-alpha.4

Expected Behavior

RRWeb should add additional load listener, not replace current, because some images have default listener. Please, replace image.onload = recordInlineImage to image.addEventListener('load', recordInlineImage).

Actual Behavior

Now RRWeb removes current load listener if inlineImages option is available.

Steps to Reproduce

Popular case for this is: <img style="opacity: 0" onload="this.style.opacity=1" />. After "inlining" this image will be not visible.

Testcase Gist URL

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant