-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprectated pipeline calls for Redis 4.6.0 #32
Fix deprectated pipeline calls for Redis 4.6.0 #32
Conversation
Redis 4.6.0 deprecates accessing `redis` within pipeline and multi calls. Fix our calls to these methods to use the PipelinedConnection given in the block argument.
Hey! Thanks for this PR!
Personally, I don't think so. Older versions of modis will work with older versions of redis and after this PR is merged and released, we'll support redis 4.6 without deprecation warnings. I don't use the
I like it! Should make maintaining a little bit easier. But we should probably then also schedule a CI run every month. |
I just saw this repo still uses Travis. I guess we should switch to GitHub actions. However I don't use |
Thanks for the review and merge @aried3r!
Yes, redis seems to follow semver, and your suggestion makes sense to me 👍 |
Switching to GH Actions in #34. |
Redis 4.6.0 deprecates accessing
redis
within pipeline and multi calls. Fix our calls to these methods to use the PipelinedConnection given in the block argument.This is to pair with the rpush PR rpush/rpush#636
Since the previous versions of redis passed the
Client
object to the block argument, our new calling syntax is compatible with both pre-4.6.0, and post-4.6.0.I made some decisions here that probably need some feedback from maintainers: