-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatability with Rails 5.2's ActiveModel::Dirty #19
Merged
Commits on Dec 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f74f02f - Browse repository at this point
Copy the full SHA f74f02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44d85c3 - Browse repository at this point
Copy the full SHA 44d85c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c63ad - Browse repository at this point
Copy the full SHA 29c63adView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe721e5 - Browse repository at this point
Copy the full SHA fe721e5View commit details -
jruby could not install this development dependency. And that is all it is, stackprof is a call-stack profiler. Not crucial to successful builds and can be added again by someone who may intend to use it.
Configuration menu - View commit details
-
Copy full SHA for f6d951f - Browse repository at this point
Copy the full SHA f6d951fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fb177a - Browse repository at this point
Copy the full SHA 6fb177aView commit details -
Compatability with Rails 5.2's ActiveModel::Dirty
* We're now expected to call `#reset_changes`, rather than manipulating `@changed_attributes` directly. * `ActiveRecord::Dirty` now assumes that any object it's included in which has an `@attributes` instance variable is database-backed, and has very specific API requirements for `@attributes` (must be an array of `ActiveModel::Attribute` instances). This conflicts with modis' `@attributes`, so we trivially renamed this to `@modis_attributes` to distinguish them.
Configuration menu - View commit details
-
Copy full SHA for b6118a0 - Browse repository at this point
Copy the full SHA b6118a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5f2f87 - Browse repository at this point
Copy the full SHA e5f2f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4694da - Browse repository at this point
Copy the full SHA e4694daView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.