Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Travis matrix with compatible Ruby/Rails versions #18

Conversation

garettarrowood
Copy link
Collaborator

No description provided.

jruby could not install this development dependency. And that is all it is, stackprof is a call-stack profiler. Not crucial to successful builds and can be added again by someone who may intend to use it.
@garettarrowood
Copy link
Collaborator Author

garettarrowood commented Dec 19, 2018

@Tonkpils @ileitch -

These CI updates are being made to provide confidence in future changes necessary for a Rails 5.2+ compatibility upgrade. Do either of you have any reservations, or a preference about stopping support for earlier versions of Rails? 3.2, 4.0 and 4.2 all seem like reasonable places to draw a line in the sand. Perhaps we could also not track Ruby versions below 2.3?

I know you two are not involved in this project much anymore. I will discuss this with my colleagues and just make a judgement call in the next 24 hours if I don't hear back.

FWIW - There appears to be some issues with Ruby 2.4.x and 2.5.x in Rails 4.0 & 4.1 . Its failed twice in CI on this combo. I'll try to address that here unless we decide to no longer support the older versions.

@benlangfeld
Copy link
Contributor

I suggest not providing support for any version of Ruby or Rails which no longer receives any kind of support from those upstream teams. This would currently mean Rails 4.2+ and Ruby 2.3+.

@benlangfeld
Copy link
Contributor

#19 incorporates these changes as well as my suggestion for support above.

@garettarrowood
Copy link
Collaborator Author

Closing in preference of #19

@garettarrowood garettarrowood deleted the setup_build_matrix_for_currently_supported_versions branch December 20, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants