Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling API keys #20

Open
pitazzo opened this issue Apr 18, 2019 · 5 comments
Open

Handling API keys #20

pitazzo opened this issue Apr 18, 2019 · 5 comments

Comments

@pitazzo
Copy link

pitazzo commented Apr 18, 2019

As long as this plugin requires the consumer key and the consumer secret in order to build a TwitterLogin instance, which is the best way to handle this situation? How secure is to hardcode those keys? Could be dangerous exposing them in a version control system?

Thanks in advance

@lukepighetti
Copy link

lukepighetti commented Sep 26, 2019

Yeah I don't understand this at all. I didn't know oauth clients ever needed the secret?

@tyrinj1120
Copy link

Other implementations for Facebook, Google etc don't require hard coding in the app. Why is this different? What are the options here for best practice?

@lukepighetti
Copy link

The only thing I can think of is to provide it over something like Remote Config but to be completely honest with you I think the method employed by this package is not safe and it shouldn't be used.

@tyrinj1120
Copy link

@lukepighetti I thought of that too but then you would have to secure that endpoint too. Then it becomes a catch 22 situation. The Twitter development ecosystem is a mess. I'm not trying to dismiss the great work of the Twitter team.

@lukepighetti
Copy link

I agree it doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants