-
Notifications
You must be signed in to change notification settings - Fork 336
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidTalkbackAccessibilityWorkaround set to true causes System.ArgumentOutOfRangeException #681
Comments
@IeuanWalker Let me investigate this, I thought it went all to smoothly, the workaround. I enabled it on my private app just then, and it seems to have worked just fine, Could you provide the entire exception callback? it may have something to do with _accessibiltyservice. (Best of all would be to create a project that shows the error I can download and tinker with directly.) |
@LuckyDucko Commenting out the Here is the output -
And here is the Appcenter crash report - I'll try and get a repo project for you today. thanks. |
@LuckyDucko here is a slimmed-down version of our project that has the issue - |
@IeuanWalker There is still an issue where a screen reader will attempt to read things in the background, I am trying to work out a way around this. One way is to make the background white, but we only want that when people are actually using the screenreader if it were to be a fix. if you have any success in that area, let me know. |
@LuckyDucko that's fixed the crashing issue. But now there are 2 issues -
Here is a video of it - 20210719_100933.1.1.mp4 |
Yeah, the underlining page title being selectable is an issue I am unsure how to fix. in testing I made the actual popup page completely hide all its features for accessibility, and STILL that went off. If I knew how to hook into the accessibility screen reader to tell me what its reading, I could have a better chance. that ones annoying. The second part is new. Let me sort it out. Edit: Fixed the issue, give it another try and let me know what you think. Issue 1 still remains |
Thanks @LuckyDucko thats fixed the main issue :) If I have time ill look into the page title issues, will let you know if I find anytyhing |
@LuckyDucko think I've found a way to fix the title issue. Do you want me to create a PR once the fixes you have done are on the develop branch? (only done a quick test, will do more testing on it tomorrow, if I get a chance) |
That would be great thanks leuan, the fixes I made are minor, so ill merge them across now |
@IeuanWalker merged in, there was an interesting point made in #585 |
@LuckyDucko just wondering if you could do a release for the crashing issue? (no rush on the PR I submitted) 😃 |
ah, @martijn00 handles the releases for this repo, as he has access to the nuget However, if you run your branch, and then reference it like I show in the video in #585 that should sort out the issue, and I can get Martijn to release your PR as the latest. I just havent found the time to do the testing that I have wanted to, might have to be done Thursday or Friday unfortunately. Sorry for the delays about it. |
🐛 Bug Report
Upgraded to NuGet version
2.0.0.12
addedAndroidTalkbackAccessibilityWorkaround="True"
to the popup page, when the popup is pushed i getSystem.ArgumentOutOfRangeException
exception.Expected behaviour
No crash
Reproduction steps
Pop page is quite basic -
XAML -
C# -
Configuration
Version: 2.0.0.12
Platform:
The text was updated successfully, but these errors were encountered: