Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings #20

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Enable warnings #20

merged 2 commits into from
Oct 1, 2020

Conversation

audrow
Copy link
Member

@audrow audrow commented Sep 22, 2020

No description provided.

@audrow audrow self-assigned this Sep 22, 2020
clalancette
clalancette approved these changes Sep 22, 2020
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI. Surprised that no code changes were necessary :).

@audrow
Enable warnings
1bb6e37 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow
Remove move in function return
e2175e5 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow
Copy link
Member Author

audrow commented Sep 24, 2020

I had to rebase because I didn't have the most recent version. I had to remove a std::move from a return statement.

Here's CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link

@sloretz Could you take a look? This is in the new code from #13

@audrow
Copy link
Member Author

audrow commented Sep 24, 2020

Here is a StackOverflow post on move in return statements.

@sloretz sloretz self-requested a review October 1, 2020 17:12
@audrow audrow merged commit 9b9e8d9 into ros2 Oct 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the audrow/add-warnings-urdf branch October 1, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@audrow @clalancette @sloretz