add imported target if TinyXML2 was found by FastRTPS #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Karsten1987
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Thanks for coming up with a solution. I am hopeful that this will solve the problem we encountered with the include order of find_package.
Two questions though:
- Would it make sense to add this logic before adding the
FindTinyXML2.cmakeonto theCMAKE_MODULE_PATHto make sure that only the existing logic for finding tinyxml2 is being used? Basically saying to put the existing linelist(INSERT ....)in anelseclause, if tinyxml2 is not found yet. - I know it's two different cmake files, but can the logic be de-duplicated? I'd prefer to maintain that custom cmake logic only in one place.
jacobperron
approved these changes
Jun 3, 2020
I would consider both for a follow up PR in order to get this fix merged asap. |
|
fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/rosbag2#429, fixes ros2/ros2#927.
Full CI: