Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change use of deprecated rclcpp APIs #343

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Change use of deprecated rclcpp APIs #343

merged 1 commit into from
Apr 12, 2019

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Apr 11, 2019 •
edited
Loading

connects to ros2/rclcpp#673

Signed-off-by: Emerson Knapp eknapp@amazon.com

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Apr 11, 2019
wjwwood
wjwwood reviewed Apr 11, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold off reviewing the other pr's until I get feedback on my suggestion.

test_rclcpp/test/test_multithreaded.cpp Outdated Show resolved Hide resolved
Move away from deprecated rclcpp APIs
4ff3910 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@emersonknapp emersonknapp changed the title Switch away from deprecated rclcpp APIs Change use of deprecated rclcpp APIs Apr 11, 2019
@wjwwood wjwwood merged commit fa71c1b into ros2:master Apr 12, 2019
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersonknapp @wjwwood @tfoote