Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert usage of tf listener node in favor of callback group #881

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

Flova
Copy link

@Flova Flova commented Jul 25, 2022

Reverts the changes from #551 as ros2/rclcpp#1218 is now merged.

The parallelism and performance should be unaffected because tf uses a callback group which is spon by its own executor instance for the tf topics. See PR ros2/geometry2#442 for the addition of this behavior.

This PR reduces the overhead from having more nodes. In addition to that, it also reduces the number of nodes in the rqt node graph and makes the subscriptions more visible, as the subscription can be directly associated with the parent node which is otherwise not the case (only something like tf_listener_xxxxx is shown, with no indication regarding the real node that creates the tf listener).

Signed-off-by: Florian Vahl <florian@flova.de>
@Flova
Copy link
Author

Flova commented Sep 1, 2022

Friendly ping @clalancette

@Flova
Copy link
Author

Flova commented Feb 15, 2023

Are there any issues with this PR? @clalancette

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant