-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computed inertia with ignition-math #751
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Relaunched CI with this PR ros2/ros2#1172 in ros2/ros2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple style related comments below.
Besides that, I'm okay with adding the new dependency, but would like a +1 from other maintainers.
rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp
Outdated
Show resolved
Hide resolved
|
Seems like a convenient library to use. +1 |
@ahcorde since this is merged, my colleagues and I are getting constantly error "The link is static or has unrealistic inertia, so the equivalent inertia box will not be shown". Thought, it is not obvious to me why this should be an error. I don't see any changes in rviz behavior than before. On the other hand to have simulation working properly inertia-values are very important so this seems to be in collision with this. What I don't understand about this? Are there any resources how to do this properly to have correct simulation and avoid this rviz error? |
@destogl do you mind to open an issue ? we can discuss there this issue. |
Signed-off-by: ahcorde ahcorde@gmail.com
Related with this issue #740