Efficiently handle 3-bytes pixel formats #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette
requested changes
Aug 16, 2021
Comment on lines
272
to
273
| for (unsigned int y = 0; y < h; y++) { | ||
| for (unsigned int x = 0; x < w; x++) { |
There was a problem hiding this comment.
Suggested change
| for (unsigned int y = 0; y < h; y++) { | |
| for (unsigned int x = 0; x < w; x++) { | |
| for (uint32_t y = 0; y < h; y++) { | |
| for (uint32_t x = 0; x < w; x++) { |
(as far as I can tell, these are always uint32_t in https://github.com/OGRECave/ogre/blob/master/OgreMain/include/OgreCommon.h#L789-L791)
(it would also be awesome to use uint32_t for w and h above)
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
clalancette
approved these changes
Aug 19, 2021
ahcorde
added a commit
that referenced
this pull request
Aug 23, 2021
* Efficiently handle 3-bytes pixel formats Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed windows warnings Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Aug 23, 2021
* Efficiently handle 3-bytes pixel formats Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed windows warnings Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Aug 23, 2021
ahcorde
added a commit
that referenced
this pull request
Sep 13, 2021
ahcorde
added a commit
that referenced
this pull request
Sep 13, 2021
[backport Foxy] Efficiently handle 3-bytes pixel formats (#743)
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2021-9-16/22372/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
Related to this commit in RVIZ1 rhaschke/rviz@2b31dc4