Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of multiline TEXT_VIEW_FACING #655

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

ipa-fez
Copy link
Contributor

@ipa-fez ipa-fez commented Feb 26, 2021

Fixes #632

@jacobperron
Copy link
Member

@ipa-fez Thanks for the fix! Mind targeting the latest development branch ros2? I'll then open a backport after.

@jacobperron jacobperron added the bug Something isn't working label Mar 12, 2021
@ipa-fez ipa-fez changed the base branch from foxy to ros2 March 12, 2021 08:44
@ipa-fez ipa-fez force-pushed the fix/multiline_text_alignment branch from bffcb48 to 2b78c69 Compare March 12, 2021 08:45
@ipa-fez
Copy link
Contributor Author

ipa-fez commented Mar 12, 2021

Ok, I've cherry-picked the commit onto the ros2 branch now.

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit cd63e71 into ros2:ros2 Mar 13, 2021
ahcorde pushed a commit that referenced this pull request Sep 13, 2021
Co-authored-by: ipa-fez <felix.zeltner@ipa.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rviz_rendering] Wrong movable text position with multiple lines
2 participants