Fix flags for both clang and gcc. #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, make sure that a clang-only flag (-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Jun 21, 2024
|
CI:
|
Crola1702
pushed a commit
that referenced
this pull request
Jun 26, 2024
In particular, make sure that a clang-only flag (-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
In particular, make sure that a clang-only flag (-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 0707355)
ahcorde
pushed a commit
that referenced
this pull request
Jun 26, 2024
In particular, make sure that a clang-only flag (-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 0707355) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, make sure that a clang-only flag
(-Wno-implicit-const-int-float-conversion) is only set for clang, and also add in another suppression for g++ 13 (where there are false warnings for stringop-overflow).
This should fix #1217