Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rviz_assimp_vendor CMake CMP0012 build error #524

Closed
rotu opened this issue Apr 6, 2020 · 3 comments · Fixed by #534
Closed

rviz_assimp_vendor CMake CMP0012 build error #524

rotu opened this issue Apr 6, 2020 · 3 comments · Fixed by #534
Assignees
@wjwwood
Labels
waiting on upstream waiting on a change in an upstream dependency

Comments

@rotu
Copy link
Contributor

rotu commented Apr 6, 2020

CMake 3.16.3 on Ubuntu Focal, building from Master

--- stderr: rviz_assimp_vendor                                                            
CMake Warning (dev) at /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimpTargets.cmake:54 (if):
  if given arguments:

    "ON"

  An argument named "ON" appears in a conditional statement.  Policy CMP0012
  is not set: if() recognizes numbers and boolean constants.  Run "cmake
  --help-policy CMP0012" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.
Call Stack (most recent call first):
  /usr/lib/x86_64-linux-gnu/cmake/assimp-5.0/assimp-config.cmake:1 (include)
  CMakeLists.txt:55 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

---

Originally (mis)filed as ros-visualization/rviz#1479
@jacobperron
Copy link
Member

jacobperron commented Apr 9, 2020 •
edited
Loading

This is caused by a bug in assimp 5.0.0 (I believed fixed in assimp 5.0.1). Here it is reported upstream: https://bugs.launchpad.net/ubuntu/+source/assimp/+bug/1869405

I'm not sure there's any way we can quiet the warning from RViz while we wait for a fix upstream...

@jacobperron jacobperron added the waiting on upstream waiting on a change in an upstream dependency label Apr 9, 2020
@nuclearsandwich nuclearsandwich mentioned this issue Apr 17, 2020
Merged
@wjwwood wjwwood assigned wjwwood and unassigned jacobperron Apr 30, 2020
@wjwwood wjwwood mentioned this issue Apr 30, 2020
Merged
@wjwwood wjwwood mentioned this issue May 14, 2020
Merged
@dirk-thomas
Copy link
Member

This is caused by a bug in assimp 5.0.0 (I believed fixed in assimp 5.0.1).

This is not fixed in 5.0.1 but on master of assimp. Atm we see the same warning on macOS: https://ci.ros2.org/view/packaging/job/packaging_osx/1870/cmake/

@dirk-thomas dirk-thomas mentioned this issue Jun 17, 2020
Merged
@jacobperron
Copy link
Member

We're also seeing the warning in PR CI builds. E.g. http://build.ros2.org/job/Rpr__rviz__ubuntu_focal_amd64/2/

mosfet80 added a commit to mosfet80/rviz that referenced this issue Jul 25, 2024
@mosfet80
Clean ogre CMakeLists.txt
a1e620f 
Assimp version always greater than 5.0.1.
# ros2#524
#   https://bugs.launchpad.net/ubuntu/+source/assimp/+bug/1869405
set(ON 1)

Remove after full revert commit 5f896af.

Signed-off-by: mosfet80 <realeandrea@yahoo.it>
@mosfet80 mosfet80 mentioned this issue Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjwwood wjwwood

Labels
waiting on upstream waiting on a change in an upstream dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

terrible hack to suppress cmake warning ros2/rviz
4 participants
@wjwwood @rotu @jacobperron @dirk-thomas