Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle and ensure the exportation of rosidl generated targets #73

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 24, 2021

Precisely what the title says. Connected to ros2/rosidl#601.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from sloretz and ivanpauno June 24, 2021 22:44
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@hidmic hidmic merged commit 6bd8c0f into master Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-target-exports branch June 30, 2021 14:50
hidmic added a commit that referenced this pull request Aug 4, 2021
…#73)"

This reverts commit 6bd8c0f.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic added a commit that referenced this pull request Aug 9, 2021
* Revert "Export rosidl_typesupport_fastrtps_c* dependencies (#75)"

This reverts commit a66d145.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Revert "Bundle and ensure the exportation of rosidl generated targets (#73)"

This reverts commit 6bd8c0f.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants