Remove python_cmake_module and set hints #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkytale
approved these changes
Feb 19, 2024
|
CI:
|
|
We should hold off on merging this one until we run CI on Windows Debug. I think there may be problems with that until we merge in ros2/ci#755 |
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
5d0afae
to
9caae66
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
9caae66
to
44f78b8
Compare
We really don't need it anymore, and can just use the builtin find_package(Python3). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
44f78b8
to
f416aad
Compare
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.