Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warnings in the benchmarks for upstream GCC false positives. #810

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Suppress warnings in the benchmarks for upstream GCC false positives. #810

merged 1 commit into from
Jun 12, 2024

Conversation

clalancette
Copy link
Contributor

This will fix at least one of the warnings as seen in https://ci.ros2.org/view/nightly/job/nightly_linux_release/3103/gcc/new/

@Crola1702 FYI

@clalancette
Suppress warnings in the benchmarks for upstream GCC false positives.
a524c2e 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
  • Linux Release Build Status

@clalancette clalancette merged commit 57940a2 into rolling Jun 12, 2024
4 checks passed
@clalancette clalancette deleted the clalancette/fix-warnings-release-mode branch June 12, 2024 19:04
@Crola1702
Copy link

Crola1702 commented Jun 18, 2024 •
edited
Loading

@clalancette this needs to be backported to Jazzy, right? (checking https://build.ros2.org/view/Jci/job/Jci__nightly-release_ubuntu_noble_amd64/24/)

Crola1702 pushed a commit that referenced this pull request Jun 26, 2024
@clalancette @Crola1702
Suppress warnings in the benchmarks for upstream GCC false positives. (…
30aaf07 
…#810)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@Crola1702 Crola1702 mentioned this pull request Jun 26, 2024
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Jun 26, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 26, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 26, 2024
@clalancette @mergify
Suppress warnings in the benchmarks for upstream GCC false positives. (…
6b73ca3 
…#810)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 57940a2)
@mergify mergify bot mentioned this pull request Jun 26, 2024
Merged
ahcorde pushed a commit that referenced this pull request Jun 26, 2024
@mergify @clalancette
Suppress warnings in the benchmarks for upstream GCC false positives. (…
d895be7 
…#810) (#816)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 57940a2)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@quarkytale quarkytale Awaiting requested review from quarkytale quarkytale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clalancette @Crola1702 @ahcorde @sloretz