Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service introspection] generate service_event messages #700

Merged
merged 54 commits into from
Feb 2, 2023
Merged

[service introspection] generate service_event messages #700

merged 54 commits into from
Feb 2, 2023

Commits on Jan 23, 2023

  1. add service event message 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    fe1f905 View commit details
    Browse the repository at this point in the history

  2. fix service introspection message compilation issues 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0b85d8c View commit details
    Browse the repository at this point in the history

  3. Add service_msgs to rosidl_cmake 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1e2ba8a View commit details
    Browse the repository at this point in the history

  4. event_messages for action services 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    45c078f View commit details
    Browse the repository at this point in the history

  5. codegen a sequence extending fn 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0f43042 View commit details
    Browse the repository at this point in the history

  6. embed message types into generated service_event msg 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    41945b8 View commit details
    Browse the repository at this point in the history

  7. add handles to creating/finalizing introspection messages to service_… 

    …introspection_info_t

Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b7d9b99 View commit details
    Browse the repository at this point in the history

  8. remote __extendn msg__function 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a076ffe View commit details
    Browse the repository at this point in the history

  9. introspection ts for service event messages 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d2d2da9 View commit details
    Browse the repository at this point in the history

  10. turn on/off enabling message payload 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    90e498a View commit details
    Browse the repository at this point in the history

  11. add service_msgs to action_msgs cmake macro 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a8c1441 View commit details
    Browse the repository at this point in the history

  12. Move common Python functions into new package 

    Deprecate the Python module in rosidl_cmake and move the implementation to the new package rosidl_pycommon.

This works towards removing a dependency on rosidl_cmake in generator packages.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    610bbf1 View commit details
    Browse the repository at this point in the history

  13. Lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b7db739 View commit details
    Browse the repository at this point in the history

  14. fix find_package-ing for packages defining services and actions 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    dccf0a1 View commit details
    Browse the repository at this point in the history

  15. use postfixes from rosidl_parser.definition and add some docs 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    957f0a9 View commit details
    Browse the repository at this point in the history

  16. missing bracket 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9743d97 View commit details
    Browse the repository at this point in the history

  17. event_messages for action services 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a4925f2 View commit details
    Browse the repository at this point in the history

  18. codegen a sequence extending fn 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f682055 View commit details
    Browse the repository at this point in the history

  19. remote __extendn msg__function 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    4d47424 View commit details
    Browse the repository at this point in the history

  20. introspection ts for service event messages 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ba1ec51 View commit details
    Browse the repository at this point in the history

  21. turn on/off enabling message payload 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    42dd4d2 View commit details
    Browse the repository at this point in the history

  22. add service_msgs to action_msgs cmake macro 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    3d5537b View commit details
    Browse the repository at this point in the history

  23. fix find_package-ing for packages defining services and actions 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    fb9c2bf View commit details
    Browse the repository at this point in the history

  24. use postfixes from rosidl_parser.definition and add some docs 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1a560be View commit details
    Browse the repository at this point in the history

  25. missing bracket 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    bbed8ad View commit details
    Browse the repository at this point in the history

  26. add service_msgs <test_depend> tag where needed 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    373cebe View commit details
    Browse the repository at this point in the history

  27. make service_introspection_message_create_handle take const void* 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    171caee View commit details
    Browse the repository at this point in the history

  28. add parser test 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    62f1f9e View commit details
    Browse the repository at this point in the history

  29. streamline rosidl_generate_interfaces cmake logic 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ca9ec5f View commit details
    Browse the repository at this point in the history

  30. add some generator tests 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9a89ee5 View commit details
    Browse the repository at this point in the history

  31. rename from introspection_message handles to event_message handles 

    Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
    @ihasdapie @clalancette
    ihasdapie authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5fdfded View commit details
    Browse the repository at this point in the history

  32. Remove duplicate template instances 

    This was probably a bug introduced during a rebase.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    820712f View commit details
    Browse the repository at this point in the history

  33. Refactor action/service loop 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d535a6e View commit details
    Browse the repository at this point in the history

  34. Use last directory in path to identify actions and services 

    This allows users to pass interfaces in nested directories, e.g. test/srv/Foo.srv, instead of requiring them to be
directly inside a 'srv' or 'action' directory relative to the cmake source directory.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ad1bd4a View commit details
    Browse the repository at this point in the history

  35. Do not rely on service_msgs_FOUND 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e0d75d1 View commit details
    Browse the repository at this point in the history

  36. Lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    96f3223 View commit details
    Browse the repository at this point in the history

  37. Fix test 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron @clalancette
    jacobperron authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    220ff59 View commit details
    Browse the repository at this point in the history

  38. Modify recursive includes in rosidl_generator_c/rosidl_generator_cpp 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    00b5433 View commit details
    Browse the repository at this point in the history

  39. add service event create/destroy function for typesupport introspecti… 

    …on c/cpp

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    68ff7b5 View commit details
    Browse the repository at this point in the history

  40. Generate only one implementation of functions per generator 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b3be446 View commit details
    Browse the repository at this point in the history

  41. Create only one create/destroy service event function for all cpp typ… 

    …esupports

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    99607ee View commit details
    Browse the repository at this point in the history

  42. Remove enable_message_payload from create service event message signa… 

    …ture

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    81e768f View commit details
    Browse the repository at this point in the history

  43. fixes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0649944 View commit details
    Browse the repository at this point in the history

  44. Add missing includes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ec537d7 View commit details
    Browse the repository at this point in the history

  45. Include name 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    11e4f8b View commit details
    Browse the repository at this point in the history

  46. Fix 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d5f40ef View commit details
    Browse the repository at this point in the history

  47. please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    785c3a1 View commit details
    Browse the repository at this point in the history

  48. Avoid signed unsigned comparison 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    84299e5 View commit details
    Browse the repository at this point in the history

  49. Complete implementation 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e842886 View commit details
    Browse the repository at this point in the history

  50. Fix rosidl_runtime_cpp linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9378583 View commit details
    Browse the repository at this point in the history

  51. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b3edf00 View commit details
    Browse the repository at this point in the history

  52. Fixes after adding tests for rosidl_typesupport_c in rosidl_typesuppo… 

    …rt_tests

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a3712ca View commit details
    Browse the repository at this point in the history

  53. Remove debug message 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno @clalancette
    ivanpauno authored and clalancette committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    00b3784 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Switch to a client_gid. 

    That is more correct, as this should not be a UUID.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    01beada View commit details
    Browse the repository at this point in the history