Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rosidl_cmake Python module to a new package rosidl_pycommon #696

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Move rosidl_cmake Python module to a new package rosidl_pycommon #696

merged 3 commits into from
Aug 10, 2022

Conversation

jacobperron
Copy link
Member

This decouples the common Python module from the package providing the cmake entrypoint.

Part of an effort to de-tangle the rosidl dependency graph and remove a dependency loop wrt to action_msgs.

@jacobperron
Move common Python functions into new package
dc8a4b1 
Deprecate the Python module in rosidl_cmake and move the implementation to the new package rosidl_pycommon.

This works towards removing a dependency on rosidl_cmake in generator packages.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace rosidl_cmake imports with rosidl_pycommon
6876438 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Aug 2, 2022
Merged
@jacobperron
Lint
1b49fb7 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced Aug 2, 2022
Merged
Merged
Merged
Merged
hidmic
hidmic approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes total sense to me, pending green CI.

We could also have tests for rosidl_pycommon now :)

@jacobperron
Copy link
Member Author

We could also have tests for rosidl_pycommon now :)

+1, I was actually thinking about doing that. Maybe in a follow-up PR to keep the changes logically separate.

@jacobperron
Copy link
Member Author

jacobperron commented Aug 9, 2022 •
edited
Loading

CI for this PR and the following connected PRs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status (unrelated test failure)

@ihasdapie ihasdapie mentioned this pull request Aug 9, 2022
Merged
@jacobperron jacobperron merged commit b8381d9 into rolling Aug 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/deprecate_rosidl_cmake_python branch August 10, 2022 00:09
@ihasdapie ihasdapie mentioned this pull request Aug 10, 2022
Closed
14 tasks
@mikaelarguedas mikaelarguedas mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@deepanshubansal01 deepanshubansal01 Awaiting requested review from deepanshubansal01

@ihasdapie ihasdapie Awaiting requested review from ihasdapie

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @hidmic