Foxy backport hex constants and tab as whitespace support #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dereck Wonnacott <dereck@gmail.com>
Signed-off-by: Dereck Wonnacott <dereck@gmail.com>
dawonn
force-pushed
the
foxy-backport-hex-and-whitespace
branch
from
5cf0acd
to
1aa7c22
Compare
|
@dawonn Please don't backport the release bump; foxy is on a different release branch with different numbering. |
dawonn
force-pushed
the
foxy-backport-hex-and-whitespace
branch
from
1aa7c22
to
c175a0b
Compare
|
Removed. |
|
Anything I can do to help push this along? I would like to release a driver with foxy support that depends on this. |
clalancette
approved these changes
Feb 25, 2021
|
CI:
|
|
None of the failed tests here seem to be because of this PR, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These backports would help me publish a new ROS2 VectorNav hardware interface that I've developed for Foxy.
Thanks Again!