Bundle and ensure the exportation of rosidl generated targets #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This was referenced Jun 24, 2021
Merged
ivanpauno
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Precisely what the title says. The rosidl pipeline was not exporting libraries and their transitive dependencies correctly, and neither was ensuring these libraries are later discovered in topological order by downstream consumers (and thus the need to bundle in a single export set).
Can you explain what this patch is doing and how does this patch fix the issue?
It isn't obvious to me
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Jun 29, 2021
|
Full CI:
|
hidmic
added a commit
that referenced
this pull request
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. The
rosidlpipeline was not exporting libraries and their transitive dependencies correctly, and neither was ensuring these libraries are later discovered in topological order by downstream consumers (and thus the need to bundle in a single export set).