Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy backport] Disable broken tests for pull requests (#440) #441

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

emersonknapp
Copy link
Collaborator

Backport #440 to Foxy branch so that future backport PRs against it can pass Action CI

Signed-off-by: Emerson Knapp eknapp@amazon.com

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@Karsten1987
Copy link
Collaborator

this should be merged into foxy branch, not master. Am I right?

@emersonknapp emersonknapp changed the base branch from master to foxy June 12, 2020 18:32
@emersonknapp
Copy link
Collaborator Author

Yes! Thanks for catching that, fixed

@Karsten1987
Copy link
Collaborator

ping @emersonknapp

@Karsten1987
Copy link
Collaborator

I'd like to merge this before #438

@emersonknapp
Copy link
Collaborator Author

Oh - sorry, I thought you were going to merge it :)

@emersonknapp emersonknapp merged commit 70b79ba into foxy Jun 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the emersonknapp/foxy-backport-disable-tests branch June 17, 2020 21:42
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-07-16/15468/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants