Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility with new IPC implementation #140

Closed
wants to merge 1 commit into from
Closed

Add compatibility with new IPC implementation #140

wants to merge 1 commit into from

Conversation

alsora
Copy link
Contributor

@alsora alsora commented Jul 9, 2019

This PR is intended to follow ros2/rclcpp#778 where a new IPC implementation is created.

The new IPC implementation introduces some changes to the Subscription and SubscriptionBase classes that affect this repository.

@alsora
update subscription creation for compatibility with new ipc changes
5bd86fe 
Signed-off-by: alberto <alberto.soragna@gmail.com>
ivanpauno
ivanpauno requested changes Jul 17, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR shouldn't be needed.
See my comment here.

@ivanpauno ivanpauno mentioned this pull request Jul 22, 2019
Merged
@alsora
Copy link
Contributor Author

alsora commented Jul 25, 2019

Closing this in favor of #143

@alsora alsora closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alsora @ivanpauno