Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read message definitions from input files in bag_rewrite #1295

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Read message definitions from input files in bag_rewrite #1295

merged 1 commit into from
Apr 15, 2023

Conversation

MichaelOrlov
Copy link
Contributor

@MichaelOrlov
Read message definitions from input files in bag_rewrite
4f22d15 
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov marked this pull request as ready for review April 15, 2023 02:21
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner April 15, 2023 02:21
@MichaelOrlov MichaelOrlov requested review from gbiggs, jhdcs, emersonknapp and james-rms and removed request for a team and gbiggs April 15, 2023 02:21
@MichaelOrlov
Copy link
Contributor Author

Gist: https://gist.githubusercontent.com/MichaelOrlov/655727b9b98e00dd71633b46185ce0f5/raw/1665b367d424c228d1a64d30adfbfa55dad79d44/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11914

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov merged commit 2ce32e7 into rolling Apr 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the morlov/update_bag_rewrite_with_stored_message_definitions branch April 15, 2023 08:08
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-05-18/31587/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-rms james-rms james-rms approved these changes

@jhdcs jhdcs Awaiting requested review from jhdcs jhdcs is a code owner automatically assigned from ros2/tooling-reviewers

@emersonknapp emersonknapp Awaiting requested review from emersonknapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelOrlov @ros-discourse @james-rms