Use mcap tarball rather than git clone #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids git lfs quota issues Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
requested review from
james-rms and
jhdcs
and removed request for
a team
james-rms
approved these changes
Dec 7, 2022
james-rms
pushed a commit
that referenced
this pull request
Dec 8, 2022
This avoids git lfs quota issues Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
james-rms
pushed a commit
that referenced
this pull request
Dec 8, 2022
This avoids git lfs quota issues Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
MichaelOrlov
pushed a commit
that referenced
this pull request
May 23, 2023
This avoids git lfs quota issues Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
MichaelOrlov
pushed a commit
that referenced
this pull request
May 23, 2023
…#1198) * [Humble backport] rosbag2_storage_mcap: merge into rosbag2 repo (#1163) (#1189) * [backport] rosbag2_storage_mcap: merge into rosbag2 repo (#1163) * rosbag2_storage_mcap: merge into ros2/rosbag2 Signed-off-by: James Smith <james@foxglove.dev> mcap_storage: 'none' is a valid storage preset profile (#86) Signed-off-by: James Smith <james@foxglove.dev> bloom: add changelog changes 0.6.0 * ci: include rosbag2_storage_mcap Signed-off-by: James Smith <james@foxglove.dev> * package.xml: include ROS Tooling WG maintainers Signed-off-by: James Smith <james@foxglove.dev> * rosbag2_storage_mcap: update readme after move Signed-off-by: James Smith <james@foxglove.dev> Signed-off-by: James Smith <james@foxglove.dev> * zstd_vendor: do not remove zstd_errors.h Signed-off-by: James Smith <james@foxglove.dev> Signed-off-by: James Smith <james@foxglove.dev> (cherry picked from commit 953c8ed) Signed-off-by: James Smith <james@foxglove.dev> * rosbag2_storage_mcap: foxy now creates bag dir Signed-off-by: James Smith <james@foxglove.dev> * Use mcap tarball rather than git clone (#1200) This avoids git lfs quota issues Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org> * mcap_vendor: install only public headers Signed-off-by: James Smith <james@foxglove.dev> move --------- Signed-off-by: James Smith <james@foxglove.dev> Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: james-rms <james@foxglove.dev> Co-authored-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids git lfs issue
Closes #1199
Signed-off-by: Michael Carroll michael@openrobotics.org