Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport galactic] snapshot feature (backport #797 #804 #837 #844 #850 #851 #877 #880) #1168

Closed
wants to merge 8 commits into from
Closed

[backport galactic] snapshot feature (backport #797 #804 #837 #844 #850 #851 #877 #880) #1168

wants to merge 8 commits into from

Conversation

YXL76
Copy link

@YXL76 YXL76 commented Nov 18, 2022

Backport #797 #804 #837 #844 #850 #851 #877 #880 to Galactic.

Barry-Xu-2018 and others added 8 commits November 18, 2022 13:14
@Barry-Xu-2018 @YXL76
Add spin_and_wait_for_matched to PublicationManager and update test c… (
a66400b 
ros2#797)

* Add spin_and_wait_for_matched to PublicationManager and update test codes

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Address review comments

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Wait without spin

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Remove unused codes and adjust default sleep time

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Fix wrong description of return value

Signed-off-by: Barry Xu <barry.xu@sony.com>
@Barry-Xu-2018 @YXL76
Make sure the subscription exists before publishing messages (ros2#804)
d02f3f3 
* Make sure the subscription exists before publishing messages

Signed-off-by: Barry Xu <barry.xu@sony.com>
@camm73 @YXL76
Design proposal for snapshot feature (ros2#837)
de68598 
* Create design proposal for snapshot feature

Co-authored-by: Cameron Miller <cammlle@amazon.com>
@camm73 @emersonknapp @YXL76
Circular Message Cache implementation for snapshot feature (ros2#844)
1f3a55a 
* Add circular message cache buffer implementation to be used for in-memory snapshot mode

Signed-off-by: Cameron Miller <cammlle@amazon.com>
Co-authored-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@camm73 @emersonknapp @YXL76
Implement snapshot mechanism and corresponding ROS Service (ros2#850)
7213702 
* Add snapshot service to recorder node
* Simplify and clarify double buffering patterns

Co-authored-by: Cameron Miller <cammlle@amazon.com>
Co-authored-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@camm73 @YXL76
Add --snapshot-mode argument to the "record" verb (ros2#851)
814a0e1 
* Add snapshot mode parameter to record verb


Signed-off-by: Cameron Miller <cammlle@amazon.com>
@clalancette @YXL76
Fix TSA warnings when building with clang thread analysis. (ros2#877)
544c16e 
In particular, mark consumer_buffer() as ACQUIRE and
release_consumer_buffer() as RELEASE.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@bastianhjaeger @YXL76
Fix typo (ros2#880)
a0e6652
@YXL76 YXL76 requested a review from a team as a code owner November 18, 2022 05:43
@YXL76 YXL76 requested review from gbiggs and emersonknapp and removed request for a team November 18, 2022 05:43
@MichaelOrlov
Copy link
Contributor

@YXL76 Thanks for your attempt bringing in this feature to the Galactic.
Unfortunately we can't backport this feature to the Galactic since it will break ABI and API compatibility and we have a strict requirement to be compatible by API and ABI for already released distros https://docs.ros.org/en/rolling/How-To-Guides/Package-maintainer-guide.html#backporting-to-released-distributions

@YXL76
Copy link
Author

YXL76 commented Nov 19, 2022

@YXL76 Thanks for your attempt bringing in this feature to the Galactic. Unfortunately we can't backport this feature to the Galactic since it will break ABI and API compatibility and we have a strict requirement to be compatible by API and ABI for already released distros https://docs.ros.org/en/rolling/How-To-Guides/Package-maintainer-guide.html#backporting-to-released-distributions

I'm sorry I missed it.

@YXL76 YXL76 closed this Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner automatically assigned from ros2/tooling-reviewers

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YXL76 @MichaelOrlov @Barry-Xu-2018 @camm73 @clalancette @bastianhjaeger