Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the ros2cli output always line buffered #659

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Make the ros2cli output always line buffered #659

merged 4 commits into from
Aug 13, 2021

Commits on Aug 11, 2021

  1. Make the ros2cli output always line buffered 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    9d5cad0 View commit details
    Browse the repository at this point in the history

  2. Add argument to avoid forcing line buffering, use TextIoWrapper recon… 

    …figure()

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    3f11cd1 View commit details
    Browse the repository at this point in the history

  3. fallback if reconfigure() method is not available 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    4556fae View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    6c5a30e View commit details
    Browse the repository at this point in the history